Don't ignore exceptions from tasks #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahus1
force-pushed
the
is-847-dont-ignore-exceptions-from-tasks
branch
from
89486ce
to
5dfbde5
Compare
Closes keycloak#847 Signed-off-by: Alexander Schwartz <[email protected]>
ahus1
force-pushed
the
is-847-dont-ignore-exceptions-from-tasks
branch
from
5dfbde5
to
92f5089
Compare
|
@kami619 - you've been involved in the original issue, maybe you could review this PR? |
kami619
reviewed
Jun 13, 2024
| } | ||
| } | ||
| if (!failures.isEmpty()) { | ||
| RuntimeException ex = new RuntimeException("Some futures failed"); |
There was a problem hiding this comment.
would it be possible to log more information about the type of failure which could help with the debug or would it log anyways ?
There was a problem hiding this comment.
The code creates a Runtime Exception which then has a list of one or more suppressed exceptions. All of the suppressed exceptions will be logged to together with the message "Some futures failed".
The the following line for where the suppressed exceptions are added.
mhajas
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According the the JavaDoc a future is also done when it failed. The current code will only show exceptions if a task that the code is waiting for is failing with an exception. Any other task that failed in the meantime is silently ignored.
Closes #847