Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial docs for JVM tuning and observability #852

Merged
merged 2 commits into from
Jun 19, 2024
Merged

initial docs for JVM tuning and observability #852

merged 2 commits into from
Jun 19, 2024

Conversation

kami619
Copy link
Contributor

@kami619 kami619 commented Jun 14, 2024 •
edited
Loading

fixes #837

@kami619 kami619 force-pushed the is-837-jvm-init-docs branch 2 times, most recently from d9657b0 to eac5240 Compare June 17, 2024 13:26
@kami619 kami619 marked this pull request as ready for review June 17, 2024 13:27
@kami619 kami619 requested a review from ahus1 June 17, 2024 13:27
ahus1
ahus1 requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, the contents looks good to me.
Still, as it is now, those new pages will not show in any navigation - please add them to the appropriate navigation.

@ahus1 ahus1 self-assigned this Jun 18, 2024
@kami619 kami619 requested a review from ahus1 June 18, 2024 13:34
@kami619
Copy link
Contributor Author

kami619 commented Jun 18, 2024

Thank you for this PR, the contents look good to me. Still, as it is now, those new pages will not show in any navigation - please add them to the appropriate navigation.

good catch @ahus1, oversight on my end. It should be addressed in my latest commit now.

kami619 and others added 2 commits June 19, 2024 12:11
@kami619 @ahus1
initial docs for JVM tuning and observability
3f61fbd 
Signed-off-by: Kamesh Akella <[email protected]>
@ahus1
Review
c6488e3 
Fixes keycloak#837

Signed-off-by: Alexander Schwartz <[email protected]>
ahus1
ahus1 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I added also the missing entries to the nav.adoc, so they'll appear as an expandable menu on the left side of the screen.

@ahus1 ahus1 merged commit 077679e into keycloak:main Jun 19, 2024
2 checks passed
@kami619 kami619 deleted the is-837-jvm-init-docs branch June 25, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahus1 ahus1 ahus1 approved these changes

Assignees

@ahus1 ahus1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document relevant metrics and JVM options that we used in determining the Keycloak JVM heap behavior
2 participants
@kami619 @ahus1