Enable External Infinispan Feature #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New option to enable external infinispan feature (disabled by default) * Added to the nightly runs to get some numbers Signed-off-by: Pedro Ruivo <[email protected]>
|
I didn't add the functional tests to the GitHub actions. I forgot. It can be merged and hope it does not break horreum :) |
ryanemerson
reviewed
Jun 25, 2024
| createCluster: false | ||
| secrets: inherit | ||
|
|
||
| run-scaling-benchmark-with-external-infinispan: |
There was a problem hiding this comment.
We're going to need a way to differentiate benchmark runs executed with "remote-cache" and normal A/P. This is also required for Active/Active. I've created #862 to address this in a separate PR.
There was a problem hiding this comment.
There was a problem hiding this comment.
It appears I'm blind, this just applies to A/A then 🎉
ryanemerson
approved these changes
Jun 25, 2024
|
Thanks @pruivo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a while since I looked at those GH action files. Please double-check if I did it right.
I tested a deployment with
KC_EXTERNAL_INFINISPAN=trueand confirmed no embedded caches were present in Keycloak Servers.