Active active test fix #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahus1
approved these changes
Jul 1, 2024
mhajas
reviewed
Jul 1, 2024
|
Good spot @mhajas, I've accepted your suggestion. |
Signed-off-by: Ryan Emerson <[email protected]>
Signed-off-by: Ryan Emerson <[email protected]>
…bhook is triggered when executing tests in close succession Signed-off-by: Ryan Emerson <[email protected]>
…ave database in an inconsistent state" This reverts commit 92cf75b. Signed-off-by: Ryan Emerson <[email protected]>
Signed-off-by: Ryan Emerson <[email protected]>
Signed-off-by: Ryan Emerson <[email protected]>
Signed-off-by: Ryan Emerson <[email protected]>
Signed-off-by: Ryan Emerson <[email protected]>
Co-authored-by: Michal Hajas <[email protected]> Signed-off-by: Ryan Emerson <[email protected]>
ryanemerson
force-pushed
the
active_active_test_fix
branch
from
2b00beb
to
eabd21f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #854
The source of the original failures was fixed by keycloak/keycloak#30841
However, when investigating the issue I realised that the testsuite was very flaky and failures often occurred when executing the
FailoverTestin conjunction with the other tests. This PR reenables the active-active tests as well adding several fixes/improvements to the testsuite to reduce the chance of flaky failures.