Skip to content

Commit

Permalink
bug: webpack issue
Browse files Browse the repository at this point in the history
For #2
  • Loading branch information
srl295 committed Nov 1, 2024
1 parent 3e03b00 commit dbcdef5
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ jobs:
- run: |
npm ci
# workaround for strange build issue #2
( mkdir -pv keyman-vancouver/node_modules/@theia/application-manager/node_modules/.bin/ && ln -sfv ../../../../../../node_modules/.bin/webpack keyman-vancouver/node_modules/@theia/application-manager/node_modules/.bin/webpack)
ls -ld keyman-vancouver/node_modules/@theia/application-manager/node_modules/.bin/webpack
wc -c keyman-vancouver/node_modules/@theia/application-manager/node_modules/.bin/webpack
find . -type f -name webpack -ls
( mkdir -pv node_modules/@theia/application-manager/node_modules/.bin/ && ln -sfv ../../../../.bin/webpack ./node_modules/@theia/application-manager/node_modules/.bin/webpack)
npm ls -a
npm run build:browser
#npm run build:electron
Expand Down
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,18 @@ Based on a generated template for [Eclipse Theia](https://theia-ide.org), this a
### Prerequisites

- Node 20 (see [.node-version](./.node-version))
- python and tools for building native modules - see this article on the Theia [prerequisites](https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#prerequisites). (Note, you don't need to install yarn directly for keyman-vancouver)
- python and tools for building native modules
- see this article on the Theia [prerequisites](https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#prerequisites)
- (Note, you don't need to install yarn directly for keyman-vancouver)
- Mac tip: `brew install python-setuptools`


### Running the browser version

npm i
# workaround for an odd issue, see #2
( mkdir -pv node_modules/@theia/application-manager/node_modules/.bin/ && ln -sfv ../../../../.bin/webpack ./node_modules/@theia/application-manager/node_modules/.bin/webpack)
npm run prepare
npm run build:browser
( cd extensions/keyman-kpj ; npm i ; npm run build )
npm run start:browser
Expand Down
5 changes: 5 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit dbcdef5

Please sign in to comment.