fix: Skip CDN for --debug builds #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
approved these changes
Sep 10, 2024
This will wait on keymanapp/shared-sites#28 |
This was referenced Sep 20, 2024
darcywong00
commented
Oct 23, 2024
| cd .. | ||
| else | ||
| echo "Skip Generating CDN" | ||
| fi |
There was a problem hiding this comment.
The keymanapp/help.keyman.com#1563 version also includes this
Suggested change
| fi | |
| rm -rf ../cdn/deploy | |
| fi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470 to skip generating CDN if
./build.sh --debugSince this is changing
BOOTSTRAP_VERSIONtochore/v0.10, I'm unsure if we want to merge this to master. Or have a separate branch while the Logo work is in flux...(edit)
BOOSTRAP_VERSION v0.10 is published so updating PR to use that.