Skip to content

Commit

Permalink
chore(linux): Ignore failed package builds for next Ubuntu differently
Browse files Browse the repository at this point in the history
Previously failed package builds for the next Ubuntu release showed up
with a green check mark. This change allows them to fail, but ignores
them for the following steps.
  • Loading branch information
ermshiperete committed Apr 3, 2024
1 parent 104680b commit 2fe4da7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/deb-packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ jobs:
sparse-checkout: '.github/actions/'

- name: Build
continue-on-error: true
uses: ./.github/actions/build-binary-packages
with:
dist: ${{ matrix.dist }}
Expand Down Expand Up @@ -194,7 +193,7 @@ jobs:
needs: [sourcepackage, binary_packages_released, binary_packages_unreleased]
runs-on: ubuntu-latest
environment: "deploy (linux)"
if: github.event.client_payload.isTestBuild == 'false'
if: ${{ github.event.client_payload.isTestBuild == 'false' && needs.sourcepackage.result == 'success' && needs.binary_packages_released.result == 'success' }}

steps:
- name: Sign packages
Expand All @@ -212,7 +211,7 @@ jobs:
needs: [sourcepackage, deb_signing]
runs-on: self-hosted
environment: "deploy (linux)"
if: github.event.client_payload.isTestBuild == 'false'
if: ${{ github.event.client_payload.isTestBuild == 'false' && needs.sourcepackage.result == 'success' && needs.deb_signing.result == 'success' }}

steps:
- name: Install dput
Expand Down Expand Up @@ -295,6 +294,7 @@ jobs:
name: Verify API for libkeymancore.so
needs: [sourcepackage, binary_packages_released]
runs-on: ubuntu-latest
if: ${{ needs.sourcepackage.result == 'success' && needs.binary_packages_released.result == 'success' }}

steps:
- name: Checkout
Expand Down

0 comments on commit 2fe4da7

Please sign in to comment.