Skip to content

Commit

Permalink
chore(linux): Revert "Ignore failed package builds for next Ubuntu di…
Browse files Browse the repository at this point in the history
…fferently"

This reverts commit 2fe4da7.

In my tests in a test repo `continue-on-error` worked as desired but also
seeds the total result as succeeded if the other jobs succeed. It's
possible that we got the behavior we saw because of syntax errors
in our file, so this change tries with the original approach again.
  • Loading branch information
ermshiperete committed Apr 3, 2024
1 parent a7fa7e2 commit 774ba9b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/deb-packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ jobs:
sparse-checkout: '.github/actions/'

- name: Build
continue-on-error: true
uses: ./.github/actions/build-binary-packages
with:
dist: ${{ matrix.dist }}
Expand Down Expand Up @@ -193,7 +194,7 @@ jobs:
needs: [sourcepackage, binary_packages_released, binary_packages_unreleased]
runs-on: ubuntu-latest
environment: "deploy (linux)"
if: ${{ github.event.client_payload.isTestBuild == 'false' && needs.sourcepackage.result == 'success' && needs.binary_packages_released.result == 'success' }}
if: github.event.client_payload.isTestBuild == 'false'

steps:
- name: Sign packages
Expand All @@ -211,7 +212,7 @@ jobs:
needs: [sourcepackage, deb_signing]
runs-on: self-hosted
environment: "deploy (linux)"
if: ${{ github.event.client_payload.isTestBuild == 'false' && needs.sourcepackage.result == 'success' && needs.deb_signing.result == 'success' }}
if: github.event.client_payload.isTestBuild == 'false'

steps:
- name: Install dput
Expand Down Expand Up @@ -294,7 +295,6 @@ jobs:
name: Verify API for libkeymancore.so
needs: [sourcepackage, binary_packages_released]
runs-on: ubuntu-latest
if: ${{ needs.sourcepackage.result == 'success' && needs.binary_packages_released.result == 'success' }}

steps:
- name: Checkout
Expand Down

0 comments on commit 774ba9b

Please sign in to comment.