refactor(web): extract the correct-and-raw-predict blocks into their own method 📚 #11888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
changed the title
predict() into smaller methods
jahorton
force-pushed
the
refactor/web/lm-worker-predict
branch
from
9d98a4a
to
b485b68
Compare
jahorton
changed the base branch from
fix/web/low-probability-exact-matching
to
refactor/web/predict-suggestion-finalization
jahorton
force-pushed
the
refactor/web/lm-worker-predict
branch
from
b485b68
to
f84c76c
Compare
jahorton
changed the base branch from
refactor/web/predict-suggestion-finalization
to
refactor/web/dedupe-and-similarity
jahorton
changed the title
predict() into smaller methods
keymanapp-test-bot
bot
removed
the
user-test-missing
…factor/web/lm-worker-predict
|
Changes in this pull request will be available for download in Keyman version 18.0.75-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #11899 (spun off from this one), this PR makes the correct-and-predict section its own method. Even on its own, the new method is pretty large, but at least its bounds are made distinct from the rest of the sections by doing so.
We can also shift to a simpler + clearer pattern for 12.0 models vs 14.0 models by returning early when the more complicated process isn't viable, which I believe does result better clarity here.
Note: reviewing with "ignore whitespace" appears to make the reviewing process much simpler for this PR.
@keymanapp-test-bot skip