change(web): locked flicks 🐵 #9957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
keymanapp-test-bot
bot
removed
the
user-test-missing
|
#9991's changeset has now been folded into this PR; it was a pretty easy rebase -> ff-only merge. |
Base automatically changed from
fix/web/gestures-and-longpress-defaults
to
feature-gestures
November 14, 2023 08:26
mcdurdin
approved these changes
Nov 15, 2023
Comment on lines
1237
to
1240
| this.gestureParams.longpress.flickDist = 0.25 * this.currentLayer.rowHeight; | ||
| this.gestureParams.flick.startDist = 0.1 * this.currentLayer.rowHeight; | ||
| this.gestureParams.flick.dirLockDist = 0.25 * this.currentLayer.rowHeight; | ||
| this.gestureParams.flick.triggerDist = 0.75 * this.currentLayer.rowHeight; |
There was a problem hiding this comment.
Should these multipliers be consts at the top of the file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a recent team meeting to examine how flicks felt, etc, this PR reworks flicks from the form seen in #9909 and #9825 to something that will hopefully feel smoother and more intuitive. To wit:
There may be a bit of fine-tuning to be done (that first reset attempt on the 'i' seems a bit odd), but the following criteria have been met:
There is a "fun" interaction between points 2 and 4 above:
As the flick-reset occurs (due to vector projection) while quite far from the original, base position, and there is no flick available in the new direction, the flick quickly cancels upon reset. That said, if there were a flick available in the new direction (via temp-edit)...
It feels a little abrupt, but not too much so. It's probably "fine"... or at least, low-priority enough that further polish work is "safe" to triage until a later point in time.
Note: I've revised things since the screen capture above, but that was done alongside work on #9972 and is hard to fully display without that. I've gone ahead and rebased the changes originally within #9991 onto this branch and done a
git merge -ff-only; its code changes were near-entirely within the same files already changed here, so the review process should be simpler as a result... even if the child PR (#9972) is needed to fully appreciate certain aspects.As such...
@keymanapp-test-bot skip
User tests will be specified either on #9972 or on its followup #9973.