Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): ldml backspace transform 🙀 #9960

Merged
merged 5 commits into from
Nov 21, 2023
Merged

feat(core): ldml backspace transform 🙀 #9960

merged 5 commits into from
Nov 21, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 7, 2023 •
edited
Loading

  • includes some subroutine refactoring

For: #9450

@keymanapp-test-bot skip

@srl295 srl295 self-assigned this Nov 7, 2023
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Nov 7, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 7, 2023 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S25 milestone Nov 7, 2023
@github-actions github-actions bot added core/ Keyman Core feat labels Nov 7, 2023
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Nov 7, 2023
@srl295
Copy link
Member Author

srl295 commented Nov 7, 2023 •
edited
Loading

includes some refactoring

@srl295 srl295 linked an issue Nov 8, 2023 that may be closed by this pull request
bug(core): ldml backspace not quite right 🙀 #9450
Closed
@mcdurdin mcdurdin modified the milestones: A17S25, A17S26 Nov 13, 2023
@mcdurdin
Copy link
Member

Hope you don't mind, will return this to draft while we wait for parent branch to stabilize and builds to pass, so it exits the review queue.

@mcdurdin mcdurdin marked this pull request as draft November 14, 2023 08:08
@srl295 srl295 force-pushed the feat/core/9468-marker-normalization-epic-ldml branch from c0fa7d1 to 7b48194 Compare November 14, 2023 13:29
@srl295
feat(core): ldml backspace transform 🙀
d0c8ea5 
- refactor keypress some (needs more)
- copypasta implementation of backspace transform

For: #9450
@srl295
feat(core): ldml backspace transform 🙀
e9e5665 
- refactor transform/normalization inner routine

For: #9450
@srl295 srl295 force-pushed the feat/core/9450-backspace-epic-ldml branch from ce45b15 to e9e5665 Compare November 16, 2023 18:27
@srl295
Copy link
Member Author

srl295 commented Nov 16, 2023

rebased

@srl295 srl295 marked this pull request as ready for review November 16, 2023 21:38
Base automatically changed from feat/core/9468-marker-normalization-epic-ldml to master November 21, 2023 21:01
@srl295 srl295 merged commit c889501 into master Nov 21, 2023
16 of 17 checks passed
@srl295 srl295 deleted the feat/core/9450-backspace-epic-ldml branch November 21, 2023 22:43
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.215-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag is a code owner

Assignees

@srl295 srl295

Labels
core/ Keyman Core feat
Projects
None yet
Milestone
A17S26
Development

Successfully merging this pull request may close these issues.

bug(core): ldml backspace not quite right 🙀
3 participants
@srl295 @mcdurdin @keyman-server