feat(developer): show .xml LDML keyboards in project 🦕 #9964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identifies .xml keyboards when building file list, then shows those appropriately in the keyboard list. Also enables grouped actions such as keyboard_compileall for those keyboards.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
69 tasks
darcywong00
reviewed
Nov 8, 2023
| @@ -80,7 +80,7 @@ | |||
| <xsl:with-param name="caption">Open</xsl:with-param> | |||
| <xsl:with-param name="command">keyman:openfile?id=<xsl:value-of select="ID" /></xsl:with-param> | |||
| </xsl:call-template> | |||
| <xsl:if test="FileType='.kmn' or FileType='.kps' or FileType='.kpp'"> | |||
| <xsl:if test="FileType='.kmn' or FileType='.kps' or FileType='.xml-ldml-keyboard'"> | |||
There was a problem hiding this comment.
Is .kpp deprecated? I don't remember ever seeing it.
There was a problem hiding this comment.
It's the old 'Keyman Product' format, for building standalone Windows products based on Keyman. A leftover from the bad old days...
mcdurdin
changed the title
Base automatically changed from
feat/developer/9948-load-xml-ldml-files
to
master
November 15, 2023 02:47
mcdurdin
deleted the
feat/developer/9948-show-ldml-xml-keyboards-in-project
branch
|
Changes in this pull request will be available for download in Keyman version 17.0.211-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #9948.
Identifies .xml keyboards when building file list, then shows those appropriately in the keyboard list. Also enables grouped actions such as keyboard_compileall for those keyboards.
XML keyboards listed in the Keyboards tab:
Note how the empty.xml is correctly identified as not a XML LDML keyboard file:
@keymanapp-test-bot skip