Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): kmx struct alignment 🙀 #9977

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 8, 2023

  • update KMX struct alignment for other platforms

For: #9138

@keymanapp-test-bot skip

@srl295 srl295 self-assigned this Nov 8, 2023
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Nov 8, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 8, 2023

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S25 milestone Nov 8, 2023
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Nov 8, 2023
@mcdurdin mcdurdin modified the milestones: A17S25, A17S26 Nov 13, 2023
@srl295 srl295 force-pushed the feat/core/9707-tertiary-reorder-epic-ldml branch from beb54bf to f7566c7 Compare November 16, 2023 18:31
- move KMX struct alignment to km_types.h

For: #9138
- add gcc / clang and msvc alignment options

For: #9138
@srl295 srl295 force-pushed the fix/common/9138-struct-alignment-epic-ldml branch from 7666d89 to b6ca0e9 Compare November 16, 2023 20:38
@srl295 srl295 marked this pull request as ready for review November 17, 2023 04:16
Base automatically changed from feat/core/9707-tertiary-reorder-epic-ldml to master November 22, 2023 00:22
@srl295 srl295 merged commit 172a84e into master Nov 22, 2023
7 checks passed
@srl295 srl295 deleted the fix/common/9138-struct-alignment-epic-ldml branch November 22, 2023 19:25
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.216-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants