Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): Project Settings Form for 17.0+ projects 🦕 #9984

Merged
merged 1 commit into from
Nov 15, 2023
Merged

feat(developer): Project Settings Form for 17.0+ projects 🦕 #9984

merged 1 commit into from
Nov 15, 2023

Conversation

mcdurdin
Copy link
Member

Relates to #9948.

User Testing

  • TEST_SETTINGS_FORM: Upgrade an existing project to the new Keyman Developer 17.0 project format. Open the Project Settings dialog, and go through and change each setting, then check that each setting is saved when you click OK and then re-open the dialog.

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Nov 13, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 13, 2023 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_SETTINGS_FORM (PASSED): Checked each field and all settings were correctly persisted

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S26 milestone Nov 13, 2023
@mcdurdin mcdurdin changed the title feat(developer): Project Settings Form for 17.0+ projects feat(developer): Project Settings Form for 17.0+ projects 🦕 Nov 13, 2023
@mcdurdin mcdurdin mentioned this pull request Nov 13, 2023
Closed
69 tasks
darcywong00
darcywong00 reviewed Nov 13, 2023
View reviewed changes
developer/src/tike/project/Keyman.Developer.UI.Project.UfrmProjectSettings20.pas
@@ -0,0 +1,82 @@
(*
Name: Keyman.Developer.UI.Project.UfrmProjectSettings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Name: Keyman.Developer.UI.Project.UfrmProjectSettings
Name: Keyman.Developer.UI.Project.UfrmProjectSettings20

darcywong00
darcywong00 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin
Copy link
Member Author

Test Results

  • TEST_SETTINGS_FORM (PASSED): Checked each field and all settings were correctly persisted

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Nov 15, 2023
Base automatically changed from fix/developer/9948-show-project-upgrade-messages-in-messages-panel to master November 15, 2023 02:47
@mcdurdin mcdurdin merged commit 8895775 into master Nov 15, 2023
5 checks passed
@mcdurdin mcdurdin deleted the feat/developer/9948-project-settings-20-form branch November 15, 2023 02:47
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.211-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcywong00 darcywong00 darcywong00 approved these changes

Assignees
No one assigned
Labels
developer/ide/ developer/ feat has-user-test
Projects
None yet
Milestone
A17S26
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdurdin @keyman-server @darcywong00