chore(developer): only build source files 🦕 #9985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For batch builds (e.g. project/compile all) of v2.0 projects, we only want to build files that are listed in the project's $SOURCEPATH, so that the project can contain extra folders with source file types that won't break a project-level build. Any source file types in extra folders can still be built one-by-one, which is helpful for investigation and test for keyboard authors, but will not be built if project build is selected. This commit also formalizes the source/ SourcePath for upgraded projects which contain a source/ folder. If the project to be upgraded does not contain the source/ folder, then no SourcePath is assigned, and any source file in any folder will be built.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
changed the title
69 tasks
Base automatically changed from
feat/developer/9948-project-settings-20-form
to
master
November 15, 2023 02:47
|
Changes in this pull request will be available for download in Keyman version 17.0.211-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #9948.
For batch builds (e.g. project/compile all) of v2.0 projects, we only want to build files that are listed in the project's $SOURCEPATH, so that the project can contain extra folders with source file types that won't break a project-level build.
Any source file types in extra folders can still be built one-by-one, which is helpful for investigation and test for keyboard authors, but will not be built if project build is selected.
This commit also formalizes the source/ SourcePath for upgraded projects which contain a source/ folder. If the project to be upgraded does not contain the source/ folder, then no SourcePath is assigned, and any source file in any folder will be built.
@keymanapp-test-bot skip