feat: Add optional 'description' field for meta description content 📓 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An upcoming keyman.com PR will have the other portion of this |
darcywong00
changed the title
rc-swag
reviewed
Oct 28, 2024
_common/MarkdownHost.php
Outdated
| @@ -16,6 +16,10 @@ function ShowMenu() { | |||
| return $this->showMenu; | |||
| } | |||
|
|
|||
| function PageDescription() { | |||
| return $this->pagedescription; | |||
There was a problem hiding this comment.
I don't know PHP but it seems this could be uninitalised as ln 92 is has an IF. This inturn will effects https://github.com/keymanapp/keyman.com/blob/1e9c090f14b795eb8aeb21704aec348d2f361b13/_includes/includes/md/mdhost.php#L17
There was a problem hiding this comment.
good point. I've updated to return an empty string if pagedescription undefined.
mcdurdin
approved these changes
Nov 1, 2024
mcdurdin
added a commit
that referenced
this pull request
Nov 1, 2024
* chore: support flag file _control/debug (#38) This will allow, for example, .htaccess directives based on the existence of the _control/debug file, so we know if we have built in debug mode or not, for example: <IfFile /var/www/html/_control/debug> ... add extra logging </IfFile> _control/debug should be added to .gitignore on all sites * fix: Account for TIER_TEST on CI runs (#35) * feat: Add optional 'description' field for meta description content 📓 (#34) * feat: Add optional 'description' field for meta description content * fix: Handle when pagedescription undefined --------- Co-authored-by: Darcy Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for keymanapp/keyman.com#383 of adding metadata description content headers for improving SEO.
This adds an optional page description field via PHP or HTML.
When a PHP file includes a description:
or when a Markdown file includes a description:
this will allow us to write HTML header info