test: try integrating alerts #40
Open
+70
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
requested changes
Nov 4, 2024
| $iconType .= $icon[$alertType] . $alertTitle; // return string | ||
| $alertContent .= ltrim($matches[2]); | ||
|
|
||
| return $block = array( |
There was a problem hiding this comment.
Suggested change
| return $block = array( | |
| return array( |
I am not sure why you were assigning $block here?
| 'caution' => '<svg class="octicon octicon-stop mr-2" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path fill="red" d="M4.47.22A.749.749 0 0 1 5 0h6c.199 0 .389.079.53.22l4.25 4.25c.141.14.22.331.22.53v6a.749.749 0 0 1-.22.53l-4.25 4.25A.749.749 0 0 1 11 16H5a.749.749 0 0 1-.53-.22L.22 11.53A.749.749 0 0 1 0 11V5c0-.199.079-.389.22-.53Zm.84 1.28L1.5 5.31v5.38l3.81 3.81h5.38l3.81-3.81V5.31L10.69 1.5ZM8 4a.75.75 0 0 1 .75.75v3.5a.75.75 0 0 1-1.5 0v-3.5A.75.75 0 0 1 8 4Zm0 8a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path></svg>', | ||
| 'warning' => '<svg class="octicon octicon-alert mr-2" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path fill="orange" d="M6.457 1.047c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0 1 14.082 15H1.918a1.75 1.75 0 0 1-1.543-2.575Zm1.763.707a.25.25 0 0 0-.44 0L1.698 13.132a.25.25 0 0 0 .22.368h12.164a.25.25 0 0 0 .22-.368Zm.53 3.996v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 11a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path></svg>' | ||
| ); | ||
| $iconType .= $icon[$alertType] . $alertTitle; // return string |
There was a problem hiding this comment.
We should check for matches for $alertType in $icon. If there is no match, then we should return plain text for the block I think.
if(empty($icon[$alertType])) {
return parent::blockQuote($block);
}
Comment on lines
+60
to
+62
| catch (Error $e) { | ||
| return $e; | ||
| } |
There was a problem hiding this comment.
I don't think it is correct to return $e? It would be safer to eliminate the try/catch altogether and let errors bubble through
| ) | ||
| ); | ||
| } | ||
| return parent::blockQuote($block); |
There was a problem hiding this comment.
It'd be better to put this in the if() block:
if(!preg_match('/^\>\s*\[\!(IMPORTANT|TIPS|NOTE|WARNING|CAUTION)\]\s(.*)/i', $block['text'], $matches)) {
return parent::blockQuote($block);
}
$alertType = strtolower($matches[1]);
...
This way, it's easier to follow the code flow
| @@ -0,0 +1,64 @@ | |||
| <?php | |||
|
|
|||
There was a problem hiding this comment.
We should add the standard Keyman header:
https://github.com/keymanapp/keyman/wiki/Keyman-Code-Style-Guide#file-header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.