Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop clearing main module's paths #67

Merged
merged 2 commits into from
May 19, 2016
Merged

Conversation

nickclaw
Copy link
Contributor

@nickclaw nickclaw commented May 11, 2016

Closes #34 and #56.

Without this fix, the following code fails with: Error: Cannot find module 'express'

var pmx = require('pmx');
pmx.init();

setTimeout(function() {
    require('express');
}, 1000);

Happy to add a test case if you need it, wasn't sure where to put it.

@Unitech
Copy link
Member

Unitech commented May 18, 2016

interesting, could you put a test file for this here: https://github.com/keymetrics/pmx/tree/master/test

nickclaw added a commit to nickclaw/pmx that referenced this pull request May 18, 2016
@nickclaw
Copy link
Contributor Author

@Unitech done!

@Unitech Unitech merged commit 5004be8 into keymetrics:master May 19, 2016
@Unitech
Copy link
Member

Unitech commented May 19, 2016

awesome thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module '<LOCAL MODULE>'
2 participants