tools,doc: apilinks should handle root scenarios

* Prevent crash when setting root properties * Allow return outside of function PR-URL: nodejs#589 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]>
kfarnung · Sep 11, 2018 · a9097d6 · a9097d6
1 parent 64bb417
commit a9097d6
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/test/fixtures/apilinks/root.js b/test/fixtures/apilinks/root.js
@@ -0,0 +1,10 @@
+'use strict';
+
+// Set root member
+let foo = true;
+foo = false;
+
+// Return outside of function
+if (!foo) {
+	return;
+}
diff --git a/test/fixtures/apilinks/root.json b/test/fixtures/apilinks/root.json
@@ -0,0 +1,2 @@
+{
+}
diff --git a/tools/doc/apilinks.js b/tools/doc/apilinks.js
@@ -52,7 +52,9 @@ process.argv.slice(2).forEach((file) => {
 
   // Parse source.
   const source = fs.readFileSync(file, 'utf8');
-  const ast = acorn.parse(source, { ecmaVersion: 10, locations: true });
+  const ast = acorn.parse(
+    source,
+    { allowReturnOutsideFunction: true, ecmaVersion: 10, locations: true });
   const program = ast.body;
 
   // Build link
@@ -67,8 +69,8 @@ process.argv.slice(2).forEach((file) => {
       if (expr.type !== 'AssignmentExpression') return;
 
       let lhs = expr.left;
-      if (expr.left.object.type === 'MemberExpression') lhs = lhs.object;
       if (lhs.type !== 'MemberExpression') return;
+      if (lhs.object.type === 'MemberExpression') lhs = lhs.object;
       if (lhs.object.name !== 'module') return;
       if (lhs.property.name !== 'exports') return;