[commands] add CustomDefault.converters to allow implicit conversions
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modeled slightly after Converters, allow specifying Converter-like class
for context-based default parameters. e.g.
```py
class Author(ParamDefault):
async def default(self, ctx):
return ctx.author
async def my_command(ctx, user: discord.Member=Author):
...
```
Also adds a few common cases (Author, Channel, Guild) for current
author, ...
khazhyk
force-pushed
the
rfc-param-default
branch
3 times, most recently
from
5c73c53 to
e62b715
Compare
khazhyk
force-pushed
the
rfc-param-default
branch
2 times, most recently
from
d774448 to
a266a02
Compare
khazhyk
force-pushed
the
rfc-param-default
branch
from
a266a02 to
be20701
Compare
Owner
|
oh I like this, neat |
khazhyk
force-pushed
the
rfc-param-default
branch
2 times, most recently
from
9677dcb to
40c234c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quick enhancement. This basically moves annotations from arguments to the
CustomDefaultclass. This adds consistency witharg=Truewhere it'll implicitly use theboolconverter. Theconvertersattribute will be ignored in the case annotations are provided in the command signature, as with theboolexample.Checklist