Remove infinitely stalling player block via rotations & add counterclockwise rotations & remap actions #31
+93
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to match tetr.io's keybindings.
…lockwise rotation on `Z`
Closed
kkysen
reviewed
Aug 20, 2022
src/GameLoop.tsx
Outdated
| !playerPhysics.isInRBounds(cell.r) || | ||
| board[cell.r][cell.c].char !== EMPTY | ||
| ) { | ||
| overlappingI = i; |
Member
There was a problem hiding this comment.
I think there's a better way to do this than filter.
kkysen
reviewed
Aug 20, 2022
| }); | ||
| if (keyCode === 37) { | ||
| // Left | ||
| if ("ArrowLeft" == code) { |
kkysen
reviewed
Aug 20, 2022
src/PlayerPhysics.tsx
Outdated
| console.log(this.adjustedCells); | ||
| const mid = Math.floor(this.layout.length / 2); | ||
| return cells.map(({ r, c, char, uid }) => { | ||
| return cells.map(({ r, c, uid, char }) => { |
Member
There was a problem hiding this comment.
Why reverse these? Keep them in the same order everywhere and where you construct them. Matters for performance a lot.
kkysen
reviewed
Aug 20, 2022
| let isPlayerMovementEnabled = false; | ||
| let didInstantDrop = false; | ||
|
|
||
| let leaveGroundPenalty = 0; |
kkysen
reviewed
Aug 20, 2022
| let didInstantDrop = false; | ||
|
|
||
| let leaveGroundPenalty = 0; | ||
| const leaveGroundRate = 250; |
Member
There was a problem hiding this comment.
This one should be fine if it's a constant.
kkysen
reviewed
Aug 20, 2022
| @@ -1,5 +1,4 @@ | |||
| import * as React from "react"; | |||
| import { useState } from "react"; | |||
Member
There was a problem hiding this comment.
Commit this change directly to main; it's separate.
kkysen
reviewed
Aug 20, 2022
| root.render( | ||
| <StrictMode> | ||
| <GameLoop/>, | ||
| <GameLoop /> |
Member
There was a problem hiding this comment.
Commit this change directly to main; it's separate.
kkysen
reviewed
Aug 20, 2022
|
|
||
| function updatePlayerPos( | ||
| { keyCode, repeat }: { keyCode: number; repeat: boolean }, | ||
| { code }: { code: string }, |
kkysen
reviewed
Aug 21, 2022
kkysen
reviewed
Aug 21, 2022
Co-authored-by: Khyber Sen <[email protected]>
Co-authored-by: Khyber Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20