Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Live Scrolling when at Page Bottom and Add Button to Scroll to Page Bottom on Web App #923

Merged
merged 9 commits into from
Sep 29, 2024

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    8666c72 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    67a01cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6eb6123 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Revert to smooth scroll on chat message streaming to reduce jitter

    - Improve function names
    - Order state updates to be more readable, logical
    debanjum committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    dbe77c6 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Fix to always scroll to most recent message on conversation first load

    Use `requestAnimationFrame' to ensure scrollToBottom called after page
    content is rendered.
    
    Previously the page wouldn't always scroll to the bottom of the page
    on conversation first load
    debanjum committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7099f5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c705435 View commit details
    Browse the repository at this point in the history
  3. Keep focus on current message when older messages fetched on scroll

    Khoj paginates fetching older messages in conversation on scroll
    up.
    
    Previously the older chat message fetch and render on scroll would
    lose the earlier scroll position and message in focus. This was very
    disorienting.
    debanjum committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    f8b5f9e View commit details
    Browse the repository at this point in the history
  4. Stabilize scroll when new messages fetched from API are rendered

    Use refs to anchor scroll on oldest previously fetched message. This
    improves reliability on scroll across different screen widths
    
    Render empty chat messages div to get stable message index to scroll
    to. Set the display to none to keep view same as before, as chat
    message box shouldn't be visible while Khoj is thinking
    debanjum committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    425b421 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Reduce distance from bottom to trigger auto scroll to 50 pixels

    This should ease scrolling up to disable auto scroll when Khoj
    response being streamed
    debanjum committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    d401860 View commit details
    Browse the repository at this point in the history