-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py #71
Update setup.py #71
Conversation
Signed-off-by: gitworkflows <[email protected]>
Reviewer's Guide by SourceryThis pull request updates the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gitworkflows - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you provide more context on why spacy is being pinned to version 3.7 specifically? Consider using a less restrictive version specifier (e.g., '~=3.7') if appropriate, to allow for minor updates and bug fixes. If version 3.7 is required for a specific reason, please add a comment in setup.py explaining this for future reference.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
User description
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Snapshots:
Include snapshots for easier review.
Checklist:
PR Type
enhancement, dependencies
Description
spacy
dependency insetup.py
to a fixed version3.7
instead of a minimum version requirement.spacy
.Changes walkthrough 📝
setup.py
Update `spacy` dependency version to a fixed version
setup.py
spacy
dependency from>=3.7
to
==3.7
.Summary by Sourcery
Enhancements:
spacy
dependency insetup.py
to a fixed version3.7
to ensure compatibility and stability.