limit should be a number, not a string

kickscondor · Oct 15, 2020 · bbba47c · bbba47c
1 parent 79e9484
commit bbba47c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/js/storage.js b/src/js/storage.js
@@ -452,7 +452,7 @@ module.exports = {
     // Select the top posts for every possible sort method, to give us a limited
     // index of the posts that each filter method would select.
     //
-    follow.actualLimit = follow.limit || POSTS_IN_MAIN_INDEX
+    follow.actualLimit = follow.limit ?? POSTS_IN_MAIN_INDEX
     follow.posts = frago.master(meta,
       meta.sortBy ? [meta.sortBy] : ['publishedAt', 'updatedAt'],
       follow.actualLimit)

diff --git a/src/js/view.js b/src/js/view.js
@@ -156,7 +156,7 @@ const FollowForm = (match, setup, isNew) => ({follows}, actions) => {
     <div>
       <label for="limit" class="optional">Limit</label>
       <input type="number" id="limit" value={follow.limit} min='0' step='1'
-        oninput={e => follow.limit = e.target.value} />
+        oninput={e => follow.limit = e.target.value ? parseInt(e.target.value) : undefined} />
       <p class="note">Number of recent feed entries to show. (If left blank, defaults to 10)</p>
     </div>
 
@@ -423,7 +423,7 @@ const ListFollow = ({ location, match }) => ({follows}, actions) => {
               {follow.posts instanceof Array && follow.posts.length > 0 &&
                 <div class="post">
                 <ol class="title">{(showReposts ? follow.posts : follow.posts.filter(x => !x.author || x.author === follow.author)).
-                  slice(0, follow.actualLimit || 10).map(f => {
+                  slice(0, follow.actualLimit ?? 10).map(f => {
                     let postAge = timeAgo(f[sortPosts], now)
                     return <li class={timeDarkness(f[sortPosts], now)}>
                       {f.author && f.author !== follow.author && <span class="author">{f.author}</span>}