Code Review: tik/proxy-view #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eddykasp
reviewed
Jul 5, 2022
There was a problem hiding this comment.
Another idea that could be interesting, but may be a bit out of scope or too complicated technically, would be the ability to control the values used for numerical filters from the UI. So that the rule would only define the tag and a variable to check against, and the actual value for that variable can then be set in the UI via a slider.
...s.kieler.klighd.standalone/src/de/cau/cs/kieler/klighd/standalone/KlighdStandaloneSetup.java
Outdated
Show resolved
Hide resolved
plugins/de.cau.cs.kieler.klighd/src/de/cau/cs/kieler/klighd/KlighdOptions.java
Outdated
Show resolved
Hide resolved
...ns/de.cau.cs.kieler.klighd/src/de/cau/cs/kieler/klighd/filtering/SemanticFilterRuleUtil.java
Show resolved
Hide resolved
...ns/de.cau.cs.kieler.klighd/src/de/cau/cs/kieler/klighd/filtering/SemanticFilterRuleUtil.java
Outdated
Show resolved
Hide resolved
plugins/de.cau.cs.kieler.klighd/src/de/cau/cs/kieler/klighd/filtering/SemanticFilterTag.java
Outdated
Show resolved
Hide resolved
...ns/de.cau.cs.kieler.klighd.lsp/src/de/cau/cs/kieler/klighd/lsp/utils/RenderingPreparer.xtend
Outdated
Show resolved
Hide resolved
...ns/de.cau.cs.kieler.klighd.lsp/src/de/cau/cs/kieler/klighd/lsp/utils/RenderingPreparer.xtend
Outdated
Show resolved
Hide resolved
...s.kieler.klighd.standalone/src/de/cau/cs/kieler/klighd/standalone/KlighdStandaloneSetup.java
Outdated
Show resolved
Hide resolved
plugins/de.cau.cs.kieler.klighd/src/de/cau/cs/kieler/klighd/filtering/BinaryConnective.java
Outdated
Show resolved
Hide resolved
...ns/de.cau.cs.kieler.klighd/src/de/cau/cs/kieler/klighd/filtering/SemanticFilterRuleUtil.java
Outdated
Show resolved
Hide resolved
plugins/de.cau.cs.kieler.klighd/src/de/cau/cs/kieler/klighd/util/KlighdProperties.java
Outdated
Show resolved
Hide resolved
Eddykasp
reviewed
Jul 26, 2022
plugins/de.cau.cs.kieler.klighd/src/de/cau/cs/kieler/klighd/KlighdOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Max Kasperowski <[email protected]>
Signed-off-by: Max Kasperowski <[email protected]>
Signed-off-by: Max Kasperowski <[email protected]>
Signed-off-by: Max Kasperowski <[email protected]>
Update java version requirements
....cs.kieler.klighd/src/de/cau/cs/kieler/klighd/filtering/parser/SemanticFilterRuleParser.java
Show resolved
Hide resolved
....cs.kieler.klighd/src/de/cau/cs/kieler/klighd/filtering/parser/SemanticFilterRuleParser.java
Show resolved
Hide resolved
....cs.kieler.klighd/src/de/cau/cs/kieler/klighd/filtering/parser/SemanticFilterRuleParser.java
Show resolved
Hide resolved
|
javadoc doesn't like the doc comments in some of these files |
NiklasRentzCAU
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kieler/klighd-vscode#86
kieler/semantics#54