Merge pull request #158 from kieler/sdo/firefoxIconSize

Added sidebar icon size css class as a workaround.
kieler · Jan 10, 2024 · 4db9d95 · 4db9d95
2 parents ffddec4 + 68433fe
commit 4db9d95
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/packages/klighd-core/src/feather-icons-snabbdom/feather-icons-snabbdom.tsx b/packages/klighd-core/src/feather-icons-snabbdom/feather-icons-snabbdom.tsx
@@ -33,13 +33,14 @@ export function FeatherIcon(paramProps: { iconId: FeatherIconNames }): VNode {
   // Imitates what feather would usually do, all attributes are put in the styles (if possible) and
   // the classes are written in as well. Missing are the xmlns and viewBox, but they do not seem to
   // be necessary anyways.
-  const classes: Record<string, boolean> = {"feather": true}
+  const classes: Record<string, boolean> = {"feather": true, "sidebar-icon-size": true}
   classes[`feather-${props.iconId}`] = true
 
   return <svg 
     style={{
-      width: '24',
-      height: '24',
+      // FIXME This actual size of the svg is now captured by the sidebar-icon-size class.
+      // width: '24', 
+      // height: '24',
       fill: 'none',
       stroke: 'currentColor',
       strokeWidth: '2',

diff --git a/packages/klighd-core/styles/sidebar.css b/packages/klighd-core/styles/sidebar.css
@@ -110,4 +110,9 @@
 
 .sidebar__enabled-button {
     --background: var(--kdc-color-sidebar-trigger-background-active);
+}
+
+.sidebar-icon-size {
+    width: 24px;
+    height: 24px;
 }