Fixes highlighting using wrong validation data#107
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
This PR aims to make STPA highlighting use validation data from the currently active document instead of whichever .stpa file was validated last. It does that by threading document URIs through validation state and diagram generation so missing-reference and missing-feedback highlights can be resolved per file.
Changes:
- Replaced global validator state for missing references/feedback with URI-keyed caches.
- Captured the active document URI during validation and diagram generation.
- Updated diagram creation to read missing-reference and missing-feedback data from the URI-specific validator entries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
extension/src-language-server/stpa/services/stpa-validator.ts |
Stores missing-reference and missing-feedback validation results per document URI instead of globally. |
extension/src-language-server/stpa/diagram/diagram-generator.ts |
Passes the active document URI into graph generation and reads URI-scoped validation data for highlighting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Drakae
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where highlighting for:
was based on the previously validated
.stpafile instead of the currently active one.