Jep/utility#108
Merged
Merged
Conversation
Drakae
commented
Jun 30, 2026
Contributor
- adjusted fault tree visualization (condition for inhibit gate is now right with port east)
- option to hide redundant gates in fault trees
- causal factors are not in camel case
There was a problem hiding this comment.
Pull request overview
This PR refines the fault tree (FTA) rendering pipeline in the language server and webview by improving gate/condition visualization and introducing a synthesis option to hide “redundant” gates, along with a STPA grammar tweak for causal-factor naming.
Changes:
- Adjust K/N gate label positioning in the webview renderer.
- Add a new FTA synthesis option to show/hide redundant gates and update diagram generation/layout behavior (including inhibit-gate condition port placement).
- Change STPA
CausalFactorliterals to PascalCase and update FTA top-event naming to include hazard ID.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| extension/src-webview/views-rendering.tsx | Centers the K/N gate text label horizontally. |
| extension/src-language-server/stpa/stpa.langium | Updates CausalFactor keyword literals (currently a breaking change). |
| extension/src-language-server/stpa/ftaGeneration/fta-generation.ts | Includes hazard name in generated FTA top-event label. |
| extension/src-language-server/fta/diagram/fta-synthesis-options.ts | Introduces “Show Redundant Gates” synthesis option (and exposes getter). |
| extension/src-language-server/fta/diagram/fta-layout-config.ts | Enables ELK hierarchy handling to include children. |
| extension/src-language-server/fta/diagram/fta-diagram-generator.ts | Implements redundant-gate hiding, fixes inhibit-gate condition port side, and adjusts gate-description generation flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
145
to
+149
| CausalFactor returns string: | ||
| 'controlAction' | 'inadequateOperation' | 'delayedOperation' | 'componentFailure' | 'changesOverTime' | | ||
| 'conflictingCA' | 'wrongProcessInput' | 'disturbance' | 'processOutput' | 'delayedFeedback' | | ||
| 'measurementInaccurate' | 'incorrectInformationProvided' | 'missingFeedback' | 'inadequateControlAlgorithm' | | ||
| 'wrongProcessModel' | 'wrongControlInput'; | ||
| 'ControlAction' | 'InadequateOperation' | 'DelayedOperation' | 'ComponentFailure' | 'ChangesOverTime' | | ||
| 'ConflictingCA' | 'WrongProcessInput' | 'Disturbance' | 'ProcessOutput' | 'DelayedFeedback' | | ||
| 'MeasurementInaccurate' | 'IncorrectInformationProvided' | 'MissingFeedback' | 'InadequateControlAlgorithm' | | ||
| 'WrongProcessModel' | 'WrongControlInput'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.