feat(LAB-2828): add guard for infinite loop in native video async import #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, for native video imports, the label-import has a version of the SDK which prevents infinite loop from : - -> backend appendManyFramesToDatasetAsynchronously - -> label-import - -> SDK append_many_to_dataset - -> backend appendManyAssets However, if the version was bumped to 2.156.0 or later, we would have had : - -> backend appendManyFramesToDatasetAsynchronously - -> label-import - -> SDK append_many_to_dataset - -> backend appendManyFramesToDatasetAsynchronously This patch prevents this infinite loop from occuring.
BlueGrizzliBear
force-pushed
the
feature/lab-2828-aa-u-when-i-upload-a-video-i-see-a-notification-when-upload
branch
from
c07fb1e
to
2eaf755
Compare
HNicolas
approved these changes
Jun 7, 2024
baptiste-olivier
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for native video imports, the label-import has a version of the SDK which prevents infinite loop from :
If the version was bumped to 2.156.0 or later, we would have had :
This patch prevents this infinite loop from occurring.