Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LAB-2828): use proper json_metadata and expect float instead of i… #1756

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix(LAB-2828): use proper json_metadata and expect float instead of i… #1756

merged 1 commit into from
Jul 30, 2024

Conversation

BlueGrizzliBear
Copy link
Contributor

Context :

  • when accessing the json_metadata key, it was trying to access the camelCase name of the attribute instead of the snake_case
  • when checking the delayDueToMinPts value, we were expecting a int, but it is actually a float.

This MR fixes this.

@BlueGrizzliBear BlueGrizzliBear self-assigned this Jul 30, 2024
@BlueGrizzliBear BlueGrizzliBear force-pushed the feature/lab-2828-aa-u-when-i-upload-a-video-i-see-a-notification-when-upload branch from 55d7a44 to 59060c0 Compare July 30, 2024 14:52
@BlueGrizzliBear BlueGrizzliBear force-pushed the feature/lab-2828-aa-u-when-i-upload-a-video-i-see-a-notification-when-upload branch from 59060c0 to a281055 Compare July 30, 2024 14:57
@aurelienlombard aurelienlombard merged commit 04a8f7f into release/2.158.0 Jul 30, 2024
12 checks passed
@aurelienlombard aurelienlombard deleted the feature/lab-2828-aa-u-when-i-upload-a-video-i-see-a-notification-when-upload branch July 30, 2024 15:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baptiste-olivier baptiste-olivier baptiste-olivier approved these changes

@aurelienlombard aurelienlombard aurelienlombard approved these changes

Assignees

@BlueGrizzliBear BlueGrizzliBear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlueGrizzliBear @baptiste-olivier @aurelienlombard