-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added subscriptions #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added subscriptions #1200
Conversation
WalkthroughUpdated README.md by adding a Subscriptions section linking to OneSearch and replacing an HTML license anchor with a Markdown license link. No code, API, or exported/public entity changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
616-619: Neutralize tone, fix bare URL (MD034), and align placement with repo scopeThe new section reads as promotional and uses a bare URL. Recommend neutral wording, a Markdown link, and (optionally) clarifying it’s a third‑party service. Also consider merging this under the existing “RSS feeds” section or renaming to “Related projects” to better fit the list’s curatorial nature.
Apply this minimal diff to improve tone and satisfy markdownlint:
-# Subscriptions - -Feel free to subscribe to the feeds with https://onesearch.blog (work in progress to add all the feeds). +# Subscriptions + +Subscribe to these feeds via [OneSearch](https://onesearch.blog). (The index is being expanded to include all feeds.)Optionally, if you prefer to integrate this under “RSS feeds” instead of a new top-level section, I can draft that revision. Would you like me to open a follow-up PR with the alternative placement and copy?
622-622: Prefer Markdown link over raw HTML for consistencyUse a standard Markdown link for consistency with the rest of the README; “rel=license” isn’t necessary in GitHub Markdown.
-Licensed under a <a rel="license" href="https://creativecommons.org/licenses/by-sa/4.0/">Creative Commons Attribution-ShareAlike 4.0 International License</a>. +Licensed under a [Creative Commons Attribution-ShareAlike 4.0 International License](https://creativecommons.org/licenses/by-sa/4.0/).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[style] ~617-~617: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...ntributing.md) first. # Subscriptions Feel free to subscribe to the feeds with https://one...
(FEEL_FREE_TO_STYLE_ME)
🪛 markdownlint-cli2 (0.17.2)
README.md
618-618: Bare URL used
(MD034, no-bare-urls)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
616-620: Neutralize tone, replace bare URL with Markdown link, and add third-party disclaimer in Subscriptions section
Apply the following diff:# Subscriptions -Subscribe to these feeds via [OneSearch](https://onesearch.blog). (The index is being expanded to include all feeds.) -Feel free to contribute the public repo for this project - https://github.com/rabbit0021/onesearch.git +Subscribe to feeds from this list via [OneSearch](https://onesearch.blog). +Contributions welcome in the [OneSearch public repository](https://github.com/rabbit0021/onesearch). +_Note: OneSearch is a third-party service and not affiliated with this list._
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[style] ~618-~618: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...s being expanded to include all feeds.) Feel free to contribute the public repo for this pro...
(FEEL_FREE_TO_STYLE_ME)
🪛 markdownlint-cli2 (0.17.2)
README.md
619-619: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
README.md (1)
623-623: License link change looks good.Clean conversion to a Markdown link; no issues.
|
@kilimchoi Could you please review this? The OneSearch project builds on top of this repo by eliminating the need for users to visit it directly—delivering curated, AI-powered recommendations and alerts whenever new content is published. Since this project served as an inspiration, I’d like to merge it for further development. |
It is amazing that this project has so many feeds but to prevent from information overload - Introducing a subscription based platform where you can subscribe to engineering blogs from feeds in this project and outside of it. It aggregates posts, uses AI to categorise them, and sends you alerts so you never miss an update. I’m also working on features like recommendations and rankings to boost content relevance.
Repo - https://github.com/rabbit0021/onesearch
The goal is simple: help developers gain practical knowledge. Down the line, I’m even thinking about adding a discussion forum around these blogs to spark deeper conversations.
Summary by CodeRabbit