Support twitch.tv

killergerbah · Feb 28, 2024 · 0d530de · 0d530de
1 parent f542a39
commit 0d530de
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 8 deletions.
diff --git a/extension/src/controllers/video-data-sync-controller.ts b/extension/src/controllers/video-data-sync-controller.ts
@@ -197,7 +197,7 @@ export default class VideoDataSyncController {
                 : {
                       open: true,
                       isLoading: this._context.subSyncAvailable && this._waitingForSubtitles,
-                      suggestedName: '',
+                      suggestedName: document.title,
                       selectedSubtitle: ['-'],
                       error: '',
                       showSubSelect: true,

diff --git a/extension/src/pages.json b/extension/src/pages.json
@@ -87,6 +87,10 @@
             "autoSync": {
                 "enabled": true
             }
+        },
+        {
+            "host": "www.twitch.tv",
+            "allowBlankSrc": true
         }
     ]
 }
diff --git a/extension/src/services/pages.ts b/extension/src/services/pages.ts
@@ -2,10 +2,11 @@ import pagesConfig from '../pages.json';
 
 interface PageConfig {
     host: string;
-    script: string;
+    script?: string;
     path?: string;
     hash?: string;
-    autoSync: {
+    allowBlankSrc?: boolean;
+    autoSync?: {
         enabled: boolean;
         videoSrc?: string;
         elementId?: string;
@@ -40,6 +41,10 @@ export class PageDelegate {
     }
 
     loadScripts() {
+        if (this.config.script === undefined) {
+            return;
+        }
+
         const s = document.createElement('script');
         s.src = chrome.runtime.getURL(`pages/${this.config.script}`);
         s.onload = () => s.remove();
@@ -68,6 +73,7 @@ export class PageDelegate {
 
     canAutoSync(element: HTMLMediaElement) {
         return (
+            this.config.autoSync !== undefined &&
             this.config.autoSync.enabled &&
             (this.config.autoSync.elementId === undefined || element.id === this.config.autoSync.elementId) &&
             (this.config.autoSync.videoSrc === undefined || new RegExp(this.config.autoSync.videoSrc).test(element.src))

diff --git a/extension/src/video.ts b/extension/src/video.ts
@@ -1,5 +1,5 @@
 import Binding from './services/binding';
-import { currentPageDelegate } from './services/pages';
+import { PageDelegate, currentPageDelegate } from './services/pages';
 import VideoSelectController from './controllers/video-select-controller';
 import {
     CopyToClipboardMessage,
@@ -41,7 +41,11 @@ const bindToggleSidePanel = () => {
     });
 };
 
-const hasValidVideoSource = (videoElement: HTMLVideoElement) => {
+const hasValidVideoSource = (videoElement: HTMLVideoElement, page?: PageDelegate) => {
+    if (page?.config?.allowBlankSrc) {
+        return true;
+    }
+
     if (videoElement.src) {
         return true;
     }
@@ -60,7 +64,7 @@ const hasValidVideoSource = (videoElement: HTMLVideoElement) => {
 const bind = () => {
     const bindings: Binding[] = [];
     const page = currentPageDelegate();
-    let subSyncAvailable = page !== undefined;
+    let subSyncAvailable = page?.config.script !== undefined;
     let frameInfoListener: FrameInfoListener | undefined;
     let frameInfoBroadcaster: FrameInfoBroadcaster | undefined;
     const isParentDocument = window.self === window.top;
@@ -81,7 +85,7 @@ const bind = () => {
             const videoElement = videoElements[i];
             const bindingExists = bindings.filter((b) => b.video.isSameNode(videoElement)).length > 0;
 
-            if (!bindingExists && hasValidVideoSource(videoElement) && !page?.shouldIgnore(videoElement)) {
+            if (!bindingExists && hasValidVideoSource(videoElement, page) && !page?.shouldIgnore(videoElement)) {
                 const b = new Binding(videoElement, subSyncAvailable, frameInfoBroadcaster?.frameId);
                 b.bind();
                 bindings.push(b);
@@ -95,7 +99,7 @@ const bind = () => {
             for (let j = 0; j < videoElements.length; ++j) {
                 const videoElement = videoElements[j];
 
-                if (videoElement.isSameNode(b.video) && hasValidVideoSource(videoElement)) {
+                if (videoElement.isSameNode(b.video) && hasValidVideoSource(videoElement, page)) {
                     videoElementExists = true;
                     break;
                 }