Explain to user why the subtitle track selector auto-opens sometimes

common/locales/de.json

@@ -189,6 +189,7 @@
         "videoDataSync": {
             "emptySubtitleTrack": "Empty",
             "loadSubtitlesFirst": "Untertitel müssen ausgewählt werden",
+            "failedToAutoLoad": "Could not auto-load subtitles in your preferred language.",
             "rememberTrackPreference": "Remember these track choices for this site",
             "selectSubtitles": "Untertitel auswählen",
             "subtitleTrack": "Untertitelspur",

common/locales/en.json

@@ -189,6 +189,7 @@
         "videoDataSync": {
             "emptySubtitleTrack": "Empty",
             "loadSubtitlesFirst": "Subtitles must be loaded before you can start mining.",
+            "failedToAutoLoad": "Could not auto-load subtitles in your preferred language.",
             "rememberTrackPreference": "Remember these track choices for this site",
             "selectSubtitles": "Select Subtitles",
             "subtitleTrack": "Subtitle Track",

common/locales/es.json

@@ -189,6 +189,7 @@
         "videoDataSync": {
             "emptySubtitleTrack": "En Blanco",
             "loadSubtitlesFirst": "Deben cargarse los subtítulos antes de comenzar a minar",
+            "failedToAutoLoad": "Could not auto-load subtitles in your preferred language.",
             "rememberTrackPreference": "Recordar estas opciones de pista para este sitio",
             "selectSubtitles": "Seleccionar Subtítulos",
             "subtitleTrack": "Pista de Subtítulos",

common/locales/ja.json

@@ -189,6 +189,7 @@
         "videoDataSync": {
             "emptySubtitleTrack": "空",
             "loadSubtitlesFirst": "マイニングを開始する前に字幕をロードしてください。",
+            "failedToAutoLoad": "Could not auto-load subtitles in your preferred language.",
             "rememberTrackPreference": "字幕トラックの選択を記憶する",
             "selectSubtitles": "字幕を選択",
             "subtitleTrack": "字幕トラック",

common/locales/pl.json

@@ -189,6 +189,7 @@
         "videoDataSync": {
             "emptySubtitleTrack": "Pusta",
             "loadSubtitlesFirst": "Napisy muszą być załadowane zanim zaczniesz kopać.",
+            "failedToAutoLoad": "Could not auto-load subtitles in your preferred language.",
             "rememberTrackPreference": "Zapamiętaj ustawienia ścieżek dla tej strony",
             "selectSubtitles": "Wybierz napisy",
             "subtitleTrack": "Ścieżka napisów",

common/locales/pt_BR.json

@@ -189,6 +189,7 @@
         "videoDataSync": {
             "emptySubtitleTrack": "Vazio",
             "loadSubtitlesFirst": "Legendas devem ser carregadas antes que você possa começar a minerar.",
+            "failedToAutoLoad": "Could not auto-load subtitles in your preferred language.",
             "rememberTrackPreference": "Lembrar dessas escolhas de faixa para este site",
             "selectSubtitles": "Selecionar legenda",
             "subtitleTrack": "Selecionar faixa",

common/locales/ru.json

@@ -189,6 +189,7 @@
         "videoDataSync": {
             "emptySubtitleTrack": "Пусто",
             "loadSubtitlesFirst": "Прежде чем начать майнинг, надо загрузить субтитры",
+            "failedToAutoLoad": "Could not auto-load subtitles in your preferred language.",
             "rememberTrackPreference": "Запомнить мой выбор дорожек для этого сайта",
             "selectSubtitles": "Выбрать субтитры",
             "subtitleTrack": "Выбрать дорожку субтитров",

common/locales/zh_CN.json

@@ -189,6 +189,7 @@
         "videoDataSync": {
             "emptySubtitleTrack": "空的",
             "loadSubtitlesFirst": "必须先加载字幕，然后才能开始挖掘。",
+            "failedToAutoLoad": "Could not auto-load subtitles in your preferred language.",
             "rememberTrackPreference": "Remember these track choices for this site",
             "selectSubtitles": "选择字幕",
             "subtitleTrack": "字幕轨道",

common/src/model.ts

@@ -155,6 +155,12 @@ export interface VideoData {
     subtitles?: VideoDataSubtitleTrack[];
 }
 
+export enum VideoDataUiOpenReason {
+    miningCommand = 1,
+    failedToAutoLoadPreferredTrack = 2,
+    userRequested = 3,
+}
+
 export interface VideoDataUiModel {
     open?: boolean;
     isLoading?: boolean;
@@ -164,7 +170,7 @@ export interface VideoDataUiModel {
     themeType?: string;
     selectedSubtitle?: string[];
     showSubSelect?: boolean;
-    openedFromMiningCommand?: boolean;
+    openReason?: VideoDataUiOpenReason;
     defaultCheckboxState?: boolean;
 }
 

extension/src/controllers/video-data-sync-controller.ts

@@ -7,6 +7,7 @@ import {
     VideoDataUiBridgeConfirmMessage,
     VideoDataUiBridgeOpenFileMessage,
     VideoDataUiModel,
+    VideoDataUiOpenReason,
     VideoToExtensionCommand,
 } from '@project/common';
 import { AsbplayerSettings, SettingsProvider, SubtitleListPreference } from '@project/common/settings';
@@ -38,7 +39,7 @@ async function html(lang: string) {
 }
 
 interface ShowOptions {
-    openedFromMiningCommand: boolean;
+    reason: VideoDataUiOpenReason;
 }
 
 const fetchDataForLanguageOnDemand = (language: string): Promise<VideoData> => {
@@ -126,9 +127,12 @@ export default class VideoDataSyncController {
         document.dispatchEvent(new CustomEvent('asbplayer-get-synced-data'));
     }
 
-    async show({ openedFromMiningCommand }: ShowOptions) {
+    async show({ reason }: ShowOptions) {
         const client = await this._client();
-        const model = await this._buildModel({ open: true, openedFromMiningCommand });
+        const model = await this._buildModel({
+            open: true,
+            openReason: reason,
+        });
         this._prepareShow();
         client.updateState(model);
     }
@@ -227,7 +231,7 @@ export default class VideoDataSyncController {
                         this._hideAndResume();
                     }
                 } else {
-                    await this.show({ openedFromMiningCommand: false });
+                    await this.show({ reason: VideoDataUiOpenReason.failedToAutoLoadPreferredTrack });
                 }
             }
         } else if (this._frame.clientIfLoaded !== undefined) {

extension/src/services/binding.ts

@@ -42,6 +42,7 @@ import {
     SubtitleModel,
     SubtitlesToVideoMessage,
     TakeScreenshotFromExtensionMessage,
+    VideoDataUiOpenReason,
     VideoDisappearedMessage,
     VideoHeartbeatMessage,
     VideoToExtensionCommand,
@@ -1250,7 +1251,9 @@ export default class Binding {
     }
 
     showVideoDataDialog(openedFromMiningCommand: boolean) {
-        this.videoDataSyncController.show({ openedFromMiningCommand });
+        this.videoDataSyncController.show({
+            reason: openedFromMiningCommand ? VideoDataUiOpenReason.miningCommand : VideoDataUiOpenReason.userRequested,
+        });
     }
 
     async cropAndResize(tabImageDataUrl: string): Promise<string> {

extension/src/ui/components/VideoDataSyncDialog.tsx

@@ -14,7 +14,7 @@ import Typography from '@material-ui/core/Typography';
 import makeStyles from '@material-ui/styles/makeStyles';
 import Switch from '@material-ui/core/Switch';
 import LabelWithHoverEffect from '@project/common/components/LabelWithHoverEffect';
-import { ConfirmedVideoDataSubtitleTrack, VideoDataSubtitleTrack } from '@project/common';
+import { ConfirmedVideoDataSubtitleTrack, VideoDataSubtitleTrack, VideoDataUiOpenReason } from '@project/common';
 import React, { useEffect, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 
@@ -55,7 +55,7 @@ interface Props {
     selectedSubtitleTrackIds: string[];
     defaultCheckboxState: boolean;
     error: string;
-    openedFromMiningCommand: boolean;
+    openReason: VideoDataUiOpenReason;
     onCancel: () => void;
     onOpenFile: () => void;
     onConfirm: (track: ConfirmedVideoDataSubtitleTrack[], shouldRememberTrackChoices: boolean) => void;
@@ -71,7 +71,7 @@ export default function VideoDataSyncDialog({
     selectedSubtitleTrackIds,
     defaultCheckboxState,
     error,
-    openedFromMiningCommand,
+    openReason,
     onCancel,
     onOpenFile,
     onConfirm,
@@ -219,9 +219,12 @@ export default function VideoDataSyncDialog({
                 )}
             </Toolbar>
             <DialogContent>
-                {openedFromMiningCommand && (
+                {openReason === VideoDataUiOpenReason.miningCommand && (
                     <DialogContentText>{t('extension.videoDataSync.loadSubtitlesFirst')}</DialogContentText>
                 )}
+                {openReason === VideoDataUiOpenReason.failedToAutoLoadPreferredTrack && (
+                    <DialogContentText>{t('extension.videoDataSync.failedToAutoLoad')}</DialogContentText>
+                )}
                 <form>
                     <Grid container direction="column" spacing={2}>
                         <Grid item>

extension/src/ui/components/VideoDataSyncUi.tsx

@@ -13,6 +13,7 @@ import {
     VideoDataUiBridgeConfirmMessage,
     VideoDataUiBridgeOpenFileMessage,
     VideoDataUiModel,
+    VideoDataUiOpenReason,
 } from '@project/common';
 import { createTheme } from '@project/common/theme';
 import { PaletteType } from '@material-ui/core';
@@ -37,7 +38,7 @@ export default function VideoDataSyncUi({ bridge }: Props) {
     ]);
     const [selectedSubtitleTrackIds, setSelectedSubtitleTrackIds] = useState<string[]>(initialTrackIds);
     const [defaultCheckboxState, setDefaultCheckboxState] = useState<boolean>(false);
-    const [openedFromMiningCommand, setOpenedFromMiningCommand] = useState<boolean>(false);
+    const [openReason, setOpenReason] = useState<VideoDataUiOpenReason>(VideoDataUiOpenReason.userRequested);
     const [error, setError] = useState<string>('');
     const [themeType, setThemeType] = useState<string>();
 
@@ -110,8 +111,8 @@ export default function VideoDataSyncUi({ bridge }: Props) {
                 setThemeType(model.themeType);
             }
 
-            if (model.openedFromMiningCommand !== undefined) {
-                setOpenedFromMiningCommand(model.openedFromMiningCommand);
+            if (model.openReason !== undefined) {
+                setOpenReason(model.openReason);
             }
         });
     }, [bridge, t]);
@@ -159,7 +160,7 @@ export default function VideoDataSyncUi({ bridge }: Props) {
                 subtitleTracks={subtitles}
                 selectedSubtitleTrackIds={selectedSubtitleTrackIds}
                 defaultCheckboxState={defaultCheckboxState}
-                openedFromMiningCommand={openedFromMiningCommand}
+                openReason={openReason}
                 error={error}
                 onCancel={handleCancel}
                 onOpenFile={handleOpenFile}