Fix subtitle container position logic when video is far down page

- E.g. in the case of Amazon Prime when scrolling down the page and then opening a video.
killergerbah · Jul 21, 2024 · c83dacb · c83dacb
1 parent 3cf4b58
commit c83dacb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/extension/src/services/element-overlay.ts b/extension/src/services/element-overlay.ts
@@ -330,7 +330,7 @@ export class CachingElementOverlay implements ElementOverlay {
         const clampedY = Math.max(rect.top + window.scrollY, 0);
 
         if (this.offsetAnchor === OffsetAnchor.bottom) {
-            const clampedHeight = Math.min(clampedY + rect.height, window.innerHeight);
+            const clampedHeight = Math.min(clampedY + rect.height, window.innerHeight + window.scrollY);
             container.style.top = clampedHeight - this.contentPositionOffset + 'px';
             container.style.bottom = '';
         } else {
@@ -510,7 +510,7 @@ export class DefaultElementOverlay implements ElementOverlay {
         const clampedY = Math.max(rect.top + window.scrollY, 0);
 
         if (this.offsetAnchor === OffsetAnchor.bottom) {
-            const clampedHeight = Math.min(clampedY + rect.height, window.innerHeight);
+            const clampedHeight = Math.min(clampedY + rect.height, window.innerHeight + window.scrollY);
             container.style.top = clampedHeight - this.contentPositionOffset + 'px';
             container.style.bottom = '';
         } else {