Subtitle end timestamps are not inclusive

killergerbah · Aug 4, 2024 · f1904e1 · f1904e1
1 parent 566e2ac
commit f1904e1
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/common/subtitle-collection/subtitle-collection.ts b/common/subtitle-collection/subtitle-collection.ts
@@ -37,10 +37,12 @@ export class SubtitleCollection<T extends SubtitleModel> {
             }
 
             for (const s of subtitles) {
-                this.tree.insert([s.start, s.end], s);
+                if (s.start < s.end) {
+                    this.tree.insert([s.start, s.end - 1], s);
+                }
 
                 if (last !== undefined && last.end < s.start) {
-                    this.gapsTree.insert([last.end + 1, s.start - 1], last);
+                    this.gapsTree.insert([last.end, s.start - 1], last);
                 }
 
                 last = s;
@@ -80,7 +82,7 @@ export class SubtitleCollection<T extends SubtitleModel> {
             }
         } else if (this.options.showingCheckRadiusMs !== undefined) {
             for (const s of showing) {
-                if (willStopShowing === undefined && s.end < timestamp + this.options.showingCheckRadiusMs) {
+                if (willStopShowing === undefined && s.end <= timestamp + this.options.showingCheckRadiusMs) {
                     willStopShowing = s;
                 }