Add Emby Support #365
Merged
Add Emby Support #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killergerbah
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks for your work on this @bpwhelan . Regarding the problem with the host configuration, how likely do you think it is for an Emby user to use a non-default port? If it is not likely then I am thinking it might be reasonable to requires users to use the default port if they want to use asbplayer with Emby.
make path optional, look at both configs Remove path from emby page json check if ApiClient is und
|
Ah crap, can you run prettier on the changed files? Will merge it in after that. |
This reverts commit 2491c88.
Done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm expecting a bit of pushback, but I'm mostly happy with this as of right now.
examples of urls where we notice the video player and attempt to get subtitles.
http://ip:8096/web/index.html#!/videoosd/videoosd.html
https://emby.custom.url/web/index.html#!/videoosd/videoosd.html