-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to blur and unblur subtitle tracks on mouse hover #413
Conversation
5f48b9e
to
a9d9750
Compare
@nekorushi Thanks for taking the time to contribute your idea and implementation. The only major feedback I have is that I would prefer if the data model for the settings future-proofed itself against the possibility of more track-specific settings. This would make it more trivial to implement more of these types of settings for more than 3 tracks, with less code duplication, and with less hardcoding of keys that look like
|
common/locales/en.json
Outdated
"subtitleBlurTrack1": "Track 1", | ||
"subtitleBlurTrack2": "Track 2", | ||
"subtitleBlurTrack3": "Track 3", | ||
"subtitleBlurDescription": "Hides selected subtitle tracks by blurring them, can be unblurred on mouse hover", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Hides selected subtitle tracks by blurring them. Can be un-blurred on mouse hover.
Thanks @nekorushi for your contribution. It is close to merge, can you just make |
Hey @killergerbah sorry for the delay. I've updated the locale and some missing config found with |
Thank you @nekorushi ! |
I haven't seen this in action yet. but i have a few questions: is the blur degree adjustable and does the blur appear smoothly or not? Using stylus I made a css that does this. I would like it to be like this video. Anyway, thanks for the useful feature |
@Kellen-wq It doesn't animate. Originally I added such CSS on my side. But for the regular use it felt very annoying due to delaying the reveal. Degree is also not adjustable. I've set the blur to 10px so the text is surely not readable. The settings surely could be added but for the usability of the feature I am not sure if it's really needed. If you insist though, the earliest I could take a look would be the end of the next month due to personal plans. |
@nekorushi that's not necessary, thank you again for adding this function. |
Added setting that allows for blurring of selected subtitle tracks. When mouse hovered, they unblur.