PostMinePlayback preference #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artjomsR
force-pushed
the
feat/PostMinePlaybackPreference
branch
3 times, most recently
from
559b0fb
to
ba0c6bc
Compare
artjomsR
force-pushed
the
feat/PostMinePlaybackPreference
branch
from
ba0c6bc
to
cf2db8e
Compare
killergerbah
requested changes
May 5, 2024
common/settings/settings.ts
Outdated
| @@ -39,6 +39,7 @@ export interface AnkiSettings { | |||
| readonly maxImageHeight: number; | |||
| readonly surroundingSubtitlesCountRadius: number; | |||
| readonly surroundingSubtitlesTimeRadius: number; | |||
| readonly clickToMineDefaultPlayback: PostMinePlayback; | |||
There was a problem hiding this comment.
Looking at this now the settings categorization does seem somewhat arbitrary but I think I would still prefer for this setting to be under MiscSettings.
common/settings/settings.ts
Outdated
| @@ -39,6 +39,7 @@ export interface AnkiSettings { | |||
| readonly maxImageHeight: number; | |||
| readonly surroundingSubtitlesCountRadius: number; | |||
| readonly surroundingSubtitlesTimeRadius: number; | |||
| readonly clickToMineDefaultPlayback: PostMinePlayback; | |||
There was a problem hiding this comment.
I would name this setting something else since it applies even when not clicking to mine.
killergerbah
approved these changes
May 9, 2024
|
Thanks as always @artjomsR |
|
Always a pleasure, thanks for your hard work on this beautiful project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, 3 options to choose from for the new setting