Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple file upload button implementation #380 #434

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Multiple file upload button implementation #380 #434

wants to merge 5 commits into from

Commits on Jul 27, 2024

  1. remove duplicate ConfirmedVideoDataSubtitleTrack interface 

    ConfirmedVideoDataSubtitleTrack is identical to VideoDataSubtitleTrack,
except label is referred to as name, and url is referred to as
subtitleUrl.
    @xpire
    xpire committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    fde5d08 View commit details
    Browse the repository at this point in the history

  2. apply prettier formatting

    @xpire
    xpire committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    2a897fc View commit details
    Browse the repository at this point in the history

  3. remove duplicate class _syncDataArray

    @xpire
    xpire committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    853f5bc View commit details
    Browse the repository at this point in the history

  4. rename to EmbeddedSubtitle and add type guard to every instantiation 

    type guard will be needed later when I use the union type, to
differentiate between the type of object.
    @xpire
    xpire committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    963910f View commit details
    Browse the repository at this point in the history

  5. try implement SubtitleFile union file type but have key issue

    @xpire
    xpire committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    4eebc12 View commit details
    Browse the repository at this point in the history