Readme: update dictionaries and regex sections #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artjomsR
force-pushed
the
feat/readme_tweaks
branch
4 times, most recently
from
730ea7e
to
4a42a71
Compare
artjomsR
force-pushed
the
feat/readme_tweaks
branch
from
4a42a71
to
7cfd700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: it seems that this PR has changed all the line endings somehow, I'll update it briefly
A couple of small things that I spotted. Please feel free to amend / delete sections that you think aren't relevant.
I've also thought about git-adding the binary file for the go proxy in the repo. This would replace the 1st two steps in the
One-click mining flowsection (we can leave the original instructions below if someone still wants to compile it themselves). But the disadvantage is that these should be regenerated if the script contents changes, and it's difficult to provide these for all 3 OSes (not sure if you'd want PRs for these as it's kinda a security risk?). Still, if you have a Mac and you include the Mac binary, then you save Mac users a bit of hassle :)