Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default policy if one doesn't exist #489

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

s-cork
Copy link
Contributor

@s-cork s-cork commented Aug 8, 2024

This seems to fix the issue reported on discord

I don't know if this is a chrome bug or something else
It seems without the default policy that chrome is treating the trustedScript as a string
would be nice to know why
With the default policy added, then the default policy is used

@s-cork
Copy link
Contributor Author

s-cork commented Aug 8, 2024

It looks like it's a chrome bug:
https://wpt.live/trusted-types/eval-function-constructor.html

In my browser the last test fails
test source: https://github.com/web-platform-tests/wpt/blob/master/trusted-types/eval-function-constructor.html

(and looks like they fixed it in chrome 129)

@killergerbah killergerbah merged commit 2cd7338 into killergerbah:main Aug 9, 2024
1 check passed
@killergerbah
Copy link
Owner

Thanks @s-cork !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants