Combine Emby and Jellyfin #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looping @shekhirin in since he added the Jellyfin code. TL;DR, Having them as two seperate pages was breaking things. Emby and Jellyfin only differ on like, one line, so just merged the two. |
|
Awesome thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having two different pages is problematic without ripping apart the page detection logic, since they both default to :8096. I should have done this when I added Emby in the first place, but I was a bit lazy and didn't feel like standing up a JF instance to test.
These two use basically the same exact stuff. The only difference is line 43, which is nicely taken care of with ??. Also apikey is not needed to retrieve the subtitle stream it seems, which makes sense really.
Evidence of both working locally using the same page code. Both of these are running on :8096 on different servers.