Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Commit

Permalink
Fix input field width in google chrome
Browse files Browse the repository at this point in the history
  • Loading branch information
@simonschaufi
simonschaufi committed May 25, 2018
1 parent c72d1a4 commit 78aa7c4
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 17 deletions.
4 changes: 2 additions & 2 deletions extensions/ki_timesheets/floaters.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,11 @@
}
$view->assign('billable', array_combine($billableValues, $billableText));

echo $view->render("floaters/add_edit_timeSheetEntry.php");
echo $view->render('floaters/add_edit_timeSheetEntry.php');

break;

case "add_edit_timeSheetQuickNote":
case 'add_edit_timeSheetQuickNote':
if (isset($kga['customer'])) die();
// ================================================
// = display edit dialog for timesheet quick note =
Expand Down
2 changes: 1 addition & 1 deletion templates/scripts/floaters/add_edit_activity.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<ul>
<li>
<label for="name"><?php echo $this->translate('activity') ?>:</label>
<?php echo $this->formText('name', $this->activity['name'], ['size' => 100]); ?>
<?php echo $this->formText('name', $this->activity['name'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="defaultRate"><?php echo $this->translate('default_rate') ?>:</label>
Expand Down
26 changes: 13 additions & 13 deletions templates/scripts/floaters/add_edit_customer.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@
<ul>
<li>
<label for="name"><?php echo $this->translate('customer') ?>*:</label>
<?php echo $this->formText('name', $this->customer['name'], ['required' => 'required', 'size' => 100]); ?>
<?php echo $this->formText('name', $this->customer['name'], ['required' => 'required', 'style' => 'width:620px']); ?>
</li>
<li>
<label for="vat"><?php echo $this->translate('vat') ?>:</label>
<?php echo $this->formText('vat', $this->customer['vat'], ['size' => 100]); ?>
<?php echo $this->formText('vat', $this->customer['vat'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="visible"><?php echo $this->translate('visibility') ?>:</label>
Expand All @@ -65,7 +65,7 @@
<div class="multiFields">
<?php echo $this->formPassword('password', '', [
'disabled' => (!$this->customer['password']) ? 'disabled' : '',
'size' => 100
'style' => 'width:620px'
]); ?><br/>
<?php echo $this->formCheckbox('no_password', '1', ['class' => 'disableInput', 'checked' => !$this->customer['password']]);
echo $this->translate('nopassword') ?>
Expand All @@ -81,23 +81,23 @@
<ul>
<li>
<label for="company"><?php echo $this->translate('company') ?>:</label>
<?php echo $this->formText('company', $this->customer['company'], ['size' => 100]); ?>
<?php echo $this->formText('company', $this->customer['company'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="contactPerson"><?php echo $this->translate('contactPerson') ?>:</label>
<?php echo $this->formText('contactPerson', $this->customer['contact'], ['size' => 100]); ?>
<?php echo $this->formText('contactPerson', $this->customer['contact'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="street"><?php echo $this->translate('street') ?>:</label>
<?php echo $this->formText('street', $this->customer['street'], ['size' => 100]); ?>
<?php echo $this->formText('street', $this->customer['street'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="zipcode"><?php echo $this->translate('zipcode') ?>:</label>
<?php echo $this->formText('zipcode', $this->customer['zipcode'], ['size' => 100]); ?>
<?php echo $this->formText('zipcode', $this->customer['zipcode'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="city"><?php echo $this->translate('city') ?>:</label>
<?php echo $this->formText('city', $this->customer['city'], ['size' => 100]); ?>
<?php echo $this->formText('city', $this->customer['city'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="country"><?php echo $this->translate('country') ?>:</label>
Expand All @@ -113,23 +113,23 @@
<ul>
<li>
<label for="phone"><?php echo $this->translate('telephon') ?>:</label>
<?php echo $this->formText('phone', $this->customer['phone'], ['size' => 100]); ?>
<?php echo $this->formText('phone', $this->customer['phone'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="fax"><?php echo $this->translate('fax') ?>:</label>
<?php echo $this->formText('fax', $this->customer['fax'], ['size' => 100]); ?>
<?php echo $this->formText('fax', $this->customer['fax'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="mobile"><?php echo $this->translate('mobilephone') ?>:</label>
<?php echo $this->formText('mobile', $this->customer['mobile'], ['size' => 100]); ?>
<?php echo $this->formText('mobile', $this->customer['mobile'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="mail"><?php echo $this->translate('mail') ?>:</label>
<?php echo $this->formText('mail', $this->customer['mail'], ['size' => 100]); ?>
<?php echo $this->formText('mail', $this->customer['mail'], ['style' => 'width:620px']); ?>
</li>
<li>
<label for="homepage"><?php echo $this->translate('homepage') ?>:</label>
<?php echo $this->formText('homepage', $this->customer['homepage'], ['size' => 100]); ?>
<?php echo $this->formText('homepage', $this->customer['homepage'], ['style' => 'width:620px']); ?>
</li>
</ul>
</fieldset>
Expand Down
2 changes: 1 addition & 1 deletion templates/scripts/floaters/add_edit_project.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<fieldset id="general">
<ul>
<li><label for="name"><?php echo $this->translate('project') ?>*:</label>
<?php echo $this->formText('name', $this->project['name'], ['required' => 'required', 'size' => 100]); ?>
<?php echo $this->formText('name', $this->project['name'], ['required' => 'required', 'style' => 'width:620px']); ?>
</li>
<li><label for="customerID"><?php echo $this->translate('customer') ?>:</label>
<?php echo $this->formSelect('customerID', $this->project['customerID'], ['class' => 'formfield', 'style' => 'width:620px'], $this->customers); ?>
Expand Down

6 comments on commit 78aa7c4

@groovenectar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have caused a horizontal scrolling issue... The quickest fix I can see would be to use calc(100% - 125px) as the value... Ideally it would have ['required' => 'required', 'class' => 'input-width'] and then apply it to the .input-width class in the CSS... I haven't got a workflow put together for contributing yet, but would like to soon...

image

@simonschaufi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally valid issue. Would you like to help us to rewrite the whole form layout? I'm thinking about making it properly like bootstrap or foundation does it but it's quite a lot of work just to fix it.

@groovenectar
Copy link

@groovenectar groovenectar commented on 78aa7c4 Nov 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonschaufi, I made a pull request here for it: kimai/kimai#1265

And I'd totally like to contribute development to Kimai. Was thinking that perhaps I will ask if my job will sponsor work on it (if they decide to adapt Kimai which I think is feasible). I think that'd be a cool situation, and actually made the pull request while spinning up a test site for us to try :)

@kevinpapst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they don't use it yet, consider starting with v2 directly:
https://www.kimai.org/blog/2018/kimai-v2-announcement/

@groovenectar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinpapst I did look into that in detail. I'd used Kimai v1 for years freelancing, and did an extensive test with v2 for some time recently. I can see where I might have made the jump for freelancing, but at the moment v2 is missing some things that would keep us from being able to hit the ground running. Specifically, granular control for user access would be important, and I think that v1 does that pretty well... It's awesome that the data from v1 can be imported into v2, so we'll be able to make a transition at some point. My recommendation has been to go with v1 for the foreseeable future, and keep an eye on v2...

@kevinpapst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback @groovenectar !
One wish: please leave such feedback in the v2 issue tracker, so I know what can and needs to be improved to get further adaption in companies.

Please sign in to comment.