Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the order of arguments of _update_mems() function. No impact fu… #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

victor-psiori
Copy link

Fixed the order of arguments for the _update_mems() function of MemTransformerLM class.

  • Earlier at line:
    new_mems = self._update_mems(hids, mems, mlen, qlen)
    , arguments were passed in order: hids, mems, mlen, qlen whereas class function definition expects in order: hids, mems, qlen mlen.
  • No functional impact though since qlen and mlen are added together for calculating context token length.
  • Rest of the changes caused by Black python formatter and could be ignored.

Cheers,
victor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant