fixed the order of arguments of _update_mems() function. No impact fu… #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the order of arguments for the
_update_mems()
function ofMemTransformerLM
class.transformer-xl/pytorch/mem_transformer.py
Line 733 in 44781ed
hids, mems, mlen, qlen
whereas class function definition expects in order:hids, mems, qlen mlen
.qlen
andmlen
are added together for calculating context token length.Cheers,
victor