Repository navigation
fix(annotations): add explicit custom name for iOS targets - #127
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve the KLIB unique-name collision reported in #114 by introducing an explicit custom name for Apple-native outputs in the annotations multiplatform module.
Changes:
- Refactors Apple target declarations into a single collection and applies a shared
binaries.frameworkconfiguration. - Sets a fixed framework
baseName(ktorgen-annotations) and makes the Apple frameworks static. - Moves
watchosDeviceArm64()into the shared Apple-target block.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+94
to
+97
| iosTarget.binaries.framework { | ||
| baseName = "ktorgen-annotations" | ||
| isStatic = true | ||
| } |
Comment on lines
72
to
+75
| // Tiers are in accordance with <https://kotlinlang.org/docs/native-target-support.html> | ||
| // Tier 1 | ||
| // iOS | ||
| iosArm64() | ||
| iosX64() | ||
| iosSimulatorArm64() | ||
| // macOs | ||
| macosX64() | ||
| macosArm64() | ||
| // Tier 2 | ||
| // watchOS | ||
| watchosArm32() | ||
| watchosArm64() | ||
| watchosX64() | ||
| watchosSimulatorArm64() | ||
| // tvOS | ||
| tvosArm64() | ||
| tvosX64() | ||
| tvosSimulatorArm64() | ||
| List.of( |
Comment on lines
+112
to
+120
| metadata { | ||
| compilations.all { | ||
| def compilationName = name | ||
| compileTaskProvider.configure { | ||
| if (this instanceof KotlinCommonCompile) { | ||
| moduleName = "${project.group}:${project.name}_$compilationName" | ||
| } | ||
| } | ||
| } |
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114