Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Tss-esapi dependency to be optional #58

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

pawelpros
Copy link
Contributor

@pawelpros pawelpros commented Sep 5, 2024

Changed Tss-esapi dependency to be optional

  • Bump: tss-esapi to version 7.5.1
  • Tss-esapi dependency is now optional required only for attester and verifier features

How to use

Cargo.toml

[dependencies]
az-cvm-vtpm = { path = "../..", default-features = false }

Usage in main.rs

use az_cvm_vtpm::hcl;

fn main() {
    println!("bla: {:?}", hcl::ReportType::Tdx);
}

Testing done

  1. Checked consistency:
cargo fmt --all -- --check
cargo clippy --all-targets --all-features --all -- -D warnings
  1. Checked with semver-checks
cargo semver-checks
     Parsing az-cvm-vtpm v0.6.0 (current)
      Parsed [  17.589s] (current)
     Parsing az-cvm-vtpm v0.6.0 (baseline)
      Parsed [  16.161s] (baseline)
    Checking az-cvm-vtpm v0.6.0 -> v0.6.0 (no change)
     Checked [   0.023s] 89 checks: 88 pass, 1 fail, 0 warn, 0 skip

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_variant_added.ron

Failed in:
  variant ReportError:NvWriteFailed in /azure-cvm-tooling/az-cvm-vtpm/src/vtpm/mod.rs:93

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  33.792s] az-cvm-vtpm

  1. Checked CoCo Trustee compilation using patched version

- Bump: tss-esapi to version 7.5.1
- Tss-esapi dependency is now optional required only for attester and verifier features

Signed-off-by: Pawel Proskurnicki <[email protected]>
@mkulke mkulke merged commit a9d6b21 into kinvolk:main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants