Handle variable report_data index sizes #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
force-pushed
the
mkulke/handle-varying-report_data-len
branch
3 times, most recently
from
cede6b9 to
e5adc5b
Compare
jepio
previously approved these changes
Nov 18, 2024
fixes kinvolk#61 A caller of `get_report_with_report_data()` might provide report_data of varying sizes. We need to verify the size of the allocated nv index that holds the report data and recreate it if necessary. Integration tests have been added to test this on CVM hardware. Signed-off-by: Magnus Kulke <[email protected]>
mkulke
force-pushed
the
mkulke/handle-varying-report_data-len
branch
from
e5adc5b to
0f528c4
Compare
jepio
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle variable report_data index sizes
fixes #61
A caller of
get_report_with_report_data()might provide report_data of varying sizes. We need to verify the size of the allocated nv index that holds the report data and recreate it if necessary.How to use
Should introduce no breaking change, run the integration test on CVM hardware to confirm. Can be built locally and then copied over:
cargo test --all --features integration_test --no-run ... scp target/debug/deps/integration_tests-... azureuser@...: ssh azureuser@... sudo ./integration_tests-... --test-threads 1Testing done
Integration tests have been added to test this on CVM hardware.