Skip to content

Conversation

mkulke
Copy link
Member

@mkulke mkulke commented Aug 4, 2025

az-{snp,tdx}-vtpm crates were not using an updated az-cvm-vtpm package, resulting in breakage when trying to import either 0.7.3 crate.

az-{snp,tdx}-vtpm crates were not using an updated az-cvm-vtpm package.

Signed-off-by: Magnus Kulke <[email protected]>
@mkulke mkulke requested a review from surajssd August 4, 2025 14:20
@mkulke mkulke merged commit 29ef158 into kinvolk:main Aug 5, 2025
1 check passed
@mkulke mkulke deleted the mkulke/bump-crate-revisions branch August 5, 2025 11:59
@mkulke
Copy link
Member Author

mkulke commented Aug 5, 2025

@yafu-1 @uril

fyi: I messed up v0.7.3 and released v0.7.4 with correct workspace references, I'll yank v0.7.3 because it will not build when pulled from crates.io

@yafu-1
Copy link
Contributor

yafu-1 commented Aug 5, 2025

I messed up v0.7.3 and released v0.7.4 with correct workspace references, I'll yank v0.7.3 because it will not build when pulled from crates.io

Thanks for the heads-up!

@mkulke
Copy link
Member Author

mkulke commented Aug 5, 2025

I messed up v0.7.3 and released v0.7.4 with correct workspace references, I'll yank v0.7.3 because it will not build when pulled from crates.io

Thanks for the heads-up!

I'm not sure, this saga has ended yet... Trustee fails to verify SNP evidence now:

https://github.com/confidential-containers/trustee/actions/runs/16752913926/job/47428697317

we could only find this out after merging it, because OpenSSF doesn't like us to run PR code on self-hosted runners. It did pass the unit tests using existing fixtures, so it's not completely broken, hopefully.

@yafu-1
Copy link
Contributor

yafu-1 commented Aug 6, 2025

I messed up v0.7.3 and released v0.7.4 with correct workspace references, I'll yank v0.7.3 because it will not build when pulled from crates.io

Thanks for the heads-up!

I'm not sure, this saga has ended yet... Trustee fails to verify SNP evidence now:

https://github.com/confidential-containers/trustee/actions/runs/16752913926/job/47428697317

we could only find this out after merging it, because OpenSSF doesn't like us to run PR code on self-hosted runners. It did pass the unit tests using existing fixtures, so it's not completely broken, hopefully.

Agreed, trustee needs a patch to support az-snp-vtpm 0.7.4. Here's my draft PR:
confidential-containers/trustee#902

Test Done: I confirmed on an Azure SNP CVM with guest-components that the behavior is now consistent with the working az-snp-vtpm v0.7.1 build.

Help Needed: I couldn't run the e2e tests due to a lack of an Ubuntu system, so assistance there would be welcome to confirm there are no regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants