-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Change log level to INFO #1376
Conversation
Change log level cause "WARNING" is too sensive.
Actually it is a real problem, as FlexForm should be configured and used. |
I think then there is no need for default values here but an error message that this FlexForm must be configured. |
But then without those values the whole page crashes. |
I am with @markusweigelt here: Falling back to default values should not be considered an error. If it was we shouldn't provide default values, but immediately throw an exception when mandatory settings are not available. |
Making sure that Flexform settings are read at all (if provided) is a different issue which should not be adressed by warning about the usage of default values. Also, I think not using Flexform at all, but instead providing settings in Typoscript is perfectly fine. So, in essence: The plugins should make sure that mandatory settings are provided (and throw an error otherwise), but they should not need to worry about where those settings come from (Flexform, Typoscript, Extension config). |
Using default should not be a warning because it signals a problem and distracts from actual issues.
The following warning will be shown in the log.
I think it's useful to inform about configuration decisions without signaling a problem. I'll adjust the message accordingly.