-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up display of parent processes #6185
Conversation
Kitodo/src/main/java/org/kitodo/production/services/data/base/SearchService.java
Fixed
Show fixed
Hide fixed
8c20bca
to
266cce3
Compare
Kitodo-DataManagement/src/main/java/org/kitodo/data/elasticsearch/search/SearchRestClient.java
Fixed
Show fixed
Hide fixed
956bf22
to
662e730
Compare
Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/StructurePanel.java
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/services/data/ProcessService.java
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/StructurePanel.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and there is a big speed improvement.
Two things:
- I'm only not sure how this change will survive the hibernate-search integration as there is a total other access to this needed data.
- This change should be back ported to the 3.7.x release branch as it is a big improvement for the 3.7.x releases which may be used a long time and it is currently not possible to change the metadata of hierarchy processes with a lot of child processes.
I agree with both points. It would be great to get this improvement for Kitodo 3.7 as well. Concerning the integration of hibernate search, perhaps @matthias-ronge could weigh in on estimating wether he thinks the changes of this pull request get in the way of his ongoing works or whether they can be incorporated into hibernate search as well. |
2299a77
to
580ab16
Compare
I backported the changes to the 3.7 branch.
This was something i thought about as well. My impression from the Hibernate Branch and the discussion around it is, that we will strive to still enable index-based functionality including custom searches, when this is important for the functionality or it speeds up things significantly. |
Fixes #5934
As outlined in issue #5934, we currently face performance problems when working with parent processes in the editor, which contain a lot of children elements. In the issue discussion i thought that the problem lies in opening a lot of XML files for detection of the base type, but we are already using the index. I discovered that the problem seems to stem from accessing the index hundreds of times.
I tried to correct that and was able to bring the time to show a parent process with 600 files from more than 30 seconds to around 3 seconds.
My implementation does four things: